Repository navigation
fix(ai-review): retain coverage after stale approval dismissal - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A normal follow-up push can trigger GitHub's
dismiss_stale_reviews_on_pushrule, changing a completed bot review from APPROVED to DISMISSED. The range selector ignored that completion marker and fell back to a full review. This happened on jitsu PR #1571, run 38911236256, despite an unchanged profile/merge base and just one descendant commit.Accept valid completion markers from both APPROVED and DISMISSED trusted-bot reviews. Keep the marker version, reviewed commit ID, profile, merge base, ancestry, and different-head checks. Pending, commented, changes-requested, unmarked, or foreign reviews do not supply coverage. No prompt/profile changes are needed, so existing compatible markers remain usable.
Coverage records completed analysis independently of current merge approval. Dismissed reviews retain coverage even when dismissed manually;
incremental: falseexplicitly requests a full review.Validation: all 43 tests pass, with regression/negative cases for dismissed reviews; actionlint and git diff --check pass; fresh local review found no issues. Replaying the affected PR's pre-run review history with real Git ancestry selects
fullbefore the fix andincrementalfrom cdec9ea to 2d9bef4 after it.