[Row] Fix: db connection leakage in Err method#846
Open
Chhekur wants to merge 1 commit intojmoiron:masterfrom
Open
[Row] Fix: db connection leakage in Err method#846Chhekur wants to merge 1 commit intojmoiron:masterfrom
Chhekur wants to merge 1 commit intojmoiron:masterfrom
Conversation
Collaborator
|
Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project. I'm tempted to say that this is not a proper solution to the problem, as calling the method would always close the connection. This will break code that does a check using the method. I think the solution for this would be to add a mention in the method documentation and mention that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Outline: there is db connection leakage happening here, if someone makes a DB calls and doesn't really call any of the Scan methods where
rowsgenerally being closed via callingrows.Close()method and directly calls theErr()method overRowinstance just to check the err in that caserowscursor connection is still alive and hence it leaks the db connection.Proposed Solution: explicitly close the
rowsin the Err() method too so that it can be made sure that if someone directly calls this method without using any scanning method, still connection would be closed.