Update reflectx to allow for optional nested structs#900
Update reflectx to allow for optional nested structs#900geeeeeeeeek wants to merge 1 commit intojmoiron:masterfrom
Conversation
|
Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project. |
|
This would be insanely useful 🙏🏻 |
|
Would love for this to be merged. I have been using sqlx with these changes for some time as it is a feature I find really useful. |
|
@dlsniper This issue is precisely what forced me to ditch sqlx many years ago. Now I ran into it again in another project... Hoping to see this merged soon 🤞🏻 |
|
I tried this change in my project, and there are definitely breaking changes. The code copies from stdlib |
|
@dlsniper @ardan-bkennedy I created another followup PR: #950. It addresses incompatibility issues, adds tests, and is much shorter. It would be great if you could take a look at it! |
Based on #847, but fixed an issue that optional pointer fields are not handled correctly.