Skip to content

Don't clobber caller's client_min_messages on install (#4) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jnasbyupgrade wants to merge 1 commit into from
Closed

Don't clobber caller's client_min_messages on install (#4) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion sql/object_reference--0.2.0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
/* DO NOT EDIT - AUTO-GENERATED FILE */
SET LOCAL client_min_messages = WARNING;
/*
* Quiet the NOTICEs this install script emits (e.g. duplicate CREATE ROLE)
* without overriding a caller who has deliberately asked for even less output.
*
* CREATE EXTENSION runs the whole script in one transaction, so a blind
* `SET LOCAL client_min_messages = WARNING` clobbers the caller's setting for
* the entire statement -- including any CASCADE that pulls this extension in
* as a dependency (see issue #4). A caller who set a stricter level such as
* ERROR to keep install output quiet would be silently overridden.
*
* Instead only raise the floor to WARNING; never lower it below the level the
* caller chose. SET LOCAL inside a DO block still applies to the rest of the
* (CREATE EXTENSION) transaction, and reverts at commit so it does not leak
* into the caller's session.
*/
DO $$
DECLARE
-- client_min_messages levels ordered least-to-most severe (LOG sorts
-- between DEBUG1 and NOTICE for this GUC).
c_levels CONSTANT text[] := ARRAY[
'debug5', 'debug4', 'debug3', 'debug2', 'debug1'
, 'log', 'notice', 'warning', 'error'
];
BEGIN
IF pg_catalog.array_position(
c_levels
, pg_catalog.lower(pg_catalog.current_setting('client_min_messages'))
) < pg_catalog.array_position(c_levels, 'warning')
THEN
SET LOCAL client_min_messages = warning;
END IF;
END
$$;
\echo This extension must be loaded via 'CREATE EXTENSION object_reference;'
\echo You really, REALLY do NOT want to try and load this via psql!!!
\echo It will FAIL during pg_dump! \quit
Expand Down
34 changes: 33 additions & 1 deletion sql/object_reference.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,36 @@
SET LOCAL client_min_messages = WARNING;
/*
* Quiet the NOTICEs this install script emits (e.g. duplicate CREATE ROLE)
* without overriding a caller who has deliberately asked for even less output.
*
* CREATE EXTENSION runs the whole script in one transaction, so a blind
* `SET LOCAL client_min_messages = WARNING` clobbers the caller's setting for
* the entire statement -- including any CASCADE that pulls this extension in
* as a dependency (see issue #4). A caller who set a stricter level such as
* ERROR to keep install output quiet would be silently overridden.
*
* Instead only raise the floor to WARNING; never lower it below the level the
* caller chose. SET LOCAL inside a DO block still applies to the rest of the
* (CREATE EXTENSION) transaction, and reverts at commit so it does not leak
* into the caller's session.
*/
DO $$
DECLARE
-- client_min_messages levels ordered least-to-most severe (LOG sorts
-- between DEBUG1 and NOTICE for this GUC).
c_levels CONSTANT text[] := ARRAY[
'debug5', 'debug4', 'debug3', 'debug2', 'debug1'
, 'log', 'notice', 'warning', 'error'
];
BEGIN
IF pg_catalog.array_position(
c_levels
, pg_catalog.lower(pg_catalog.current_setting('client_min_messages'))
) < pg_catalog.array_position(c_levels, 'warning')
THEN
SET LOCAL client_min_messages = warning;
END IF;
END
$$;
\echo This extension must be loaded via 'CREATE EXTENSION object_reference;'
\echo You really, REALLY do NOT want to try and load this via psql!!!
\echo It will FAIL during pg_dump! \quit
Expand Down
10 changes: 5 additions & 5 deletions test/expected/zzz_build.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
This extension must be loaded via CREATE EXTENSION object_reference;
You really, REALLY do NOT want to try and load this via psql!!!

psql:test/temp_load.not_sql:159: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
psql:test/temp_load.not_sql:191: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!

psql:test/temp_load.not_sql:160: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
psql:test/temp_load.not_sql:192: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!






psql:test/temp_load.not_sql:414: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
psql:test/temp_load.not_sql:446: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!



Expand All @@ -21,9 +21,9 @@ psql:test/temp_load.not_sql:414: WARNING: I promise you will be sorry if you tr



psql:test/temp_load.not_sql:521: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
psql:test/temp_load.not_sql:553: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!

psql:test/temp_load.not_sql:528: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
psql:test/temp_load.not_sql:560: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!



Expand Down
Loading