Abort previous table reload on subsequent reload call#137
Open
zacherkkila wants to merge 2 commits intojoeharrison714:masterfrom
Open
Abort previous table reload on subsequent reload call#137zacherkkila wants to merge 2 commits intojoeharrison714:masterfrom
zacherkkila wants to merge 2 commits intojoeharrison714:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Long running searches can cause reload requests to stack up if typing quickly, often causing an issue where the results of the reload do not match the search. It seems to be that if the first request has not finished, the second will be ignored all together. I was able to see this very consistently on a table with 25k records
Solution: Keep a reference to the previous ajax request and call
abort()upon the next request. This will abort the previous request if it is still running allowing only the latest reload to return