Calculate buffer length of utf-8 data for json correctly#29
Open
myndzi wants to merge 1 commit intojoepie91:masterfrom
Open
Calculate buffer length of utf-8 data for json correctly#29myndzi wants to merge 1 commit intojoepie91:masterfrom
myndzi wants to merge 1 commit intojoepie91:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're explicitly calculating the utf-8 length (as far as I can tell, this is an implicit assumption overall) when encoding JSON, I made sure to add it to the Content-Type header too.
The denormalization of the content-length header is so we don't have to do the extra work of calculating the utf8-length if we don't have to.
There is no real test structure to speak of, so I just tested the failing case before and after to ensure it succeeds.
Closes #28