Replace deprecated appdirs with platformdirs#441
Open
kratos6753 wants to merge 1 commit into
Open
Conversation
Owner
|
Can you verify that this doesn't change the location of config? i don't really have a problem with changing but wouldn't want users to lose their report history when they upgrade if i can help it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279
Summary
pyinstrument/vendor/appdirs.py(the upstreamappdirsproject is officially deprecated)platformdirsas a runtime dependency insetup.py— it is the actively maintained fork recommended by theappdirsmaintainerspyinstrument/__main__.py; theuser_data_dirAPI is fully compatible so no behaviour changesTest plan
python -c "from pyinstrument.__main__ import report_dir; print(report_dir())"returns a valid pathpytest)