Skip to content

Lowercase scheme and authority per specification.#183

Open
joestump wants to merge 7 commits into
developfrom
normalize-urls-correctly
Open

Lowercase scheme and authority per specification.#183
joestump wants to merge 7 commits into
developfrom
normalize-urls-correctly

Conversation

@joestump

@joestump joestump commented Aug 2, 2015

Copy link
Copy Markdown
Owner

Closes #29. More robustly follows URL normalization per the specification now. See #133 for additional and related discussion.

@joestump

joestump commented Aug 2, 2015

Copy link
Copy Markdown
Owner Author

@jaitaiwan I'm not sure what's going on, but it appears PT3K support never passed tests? Or isn't merged into develop? Not really sure; everything says up to date with master/develope locally.

@jaitaiwan

Copy link
Copy Markdown
Contributor

We never ended up merging any py3k support into develop at all because mine was too incomplete. I don't know how it passed tests originally but it's not working now. I think the vote was on using tseaver's py3k branch and fixing the 2 tests that didn't pass.

@joestump

joestump commented Aug 2, 2015

Copy link
Copy Markdown
Owner Author

Somehow .travis.yml is running PT3K tests. No idea why because it's not in this branch?

@joestump

joestump commented Aug 2, 2015

Copy link
Copy Markdown
Owner Author

@jaitaiwan looks like you pushed PT3K builds to develop in c3d8b72. Can you back that out and move that over to the PT3K branch until it's merged in so we can merge this for 1.9RC1?

@jaitaiwan

Copy link
Copy Markdown
Contributor

Sure not a problem.

@jaitaiwan

Copy link
Copy Markdown
Contributor

@joestump change has been completed and RC1 has been tagged in a release/1.9 branch :)

@joestump

joestump commented Aug 2, 2015

Copy link
Copy Markdown
Owner Author

Tests are passing. This is ready for a final review. 👍

@jaitaiwan jaitaiwan force-pushed the develop branch 2 times, most recently from a660e24 to ea42271 Compare September 12, 2015 12:05
@TimSC

TimSC commented Jan 13, 2018

Copy link
Copy Markdown
Contributor

I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants