Skip to content

chore(claude): move universal tone/formatting rules to base.md#1721

Merged
johnae merged 1 commit into
mainfrom
push-omlqyrxolzmq
May 4, 2026
Merged

chore(claude): move universal tone/formatting rules to base.md#1721
johnae merged 1 commit into
mainfrom
push-omlqyrxolzmq

Conversation

@johnae
Copy link
Copy Markdown
Owner

@johnae johnae commented May 4, 2026

Summary

  • Move tone (conversational/direct/honest/no-emdashes) and formatting (bold/italics/emojis/code-block language) rules from users/profiles/claude/rules/writing.md into users/profiles/claude/base.md so they apply to all output, not just doc-writing contexts
  • Add restriction against the term "load-bearing"
  • writing.md now keeps only prose-specific concerns (line length, READMEs, structure priority)

Test plan

  • No code changes; rules-only refactor

@johnae johnae enabled auto-merge (squash) May 4, 2026 20:51
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 4, 2026

Claude finished @johnae's task —— View job


PR Review: Rule Refactoring to base.md

Review Progress

  • Read and analyze changes to base.md
  • Read and analyze changes to writing.md
  • Verify rule migration completeness
  • Provide comprehensive review feedback

Overall Assessment

This is a clean and logical refactoring. The changes appropriately centralize universal tone and formatting rules in base.md while keeping prose-specific concerns in writing.md.

What Changed

  1. Moved from writing.md to base.md:

    • Tone section (conversational, direct, honest guidelines)
    • Universal formatting rules (bold, italics, emojis, code blocks)
    • Added new restriction: "Never use 'load-bearing' or 'load bearing'"
  2. Kept in writing.md:

    • Line length constraint (80-100 chars)
    • README structure guidelines
    • Document priority/structure rules

Code Quality & Best Practices ✅

  • Clean separation of concerns: Universal rules now apply to all output (code comments, responses, documentation) while prose-specific rules remain isolated
  • Clear documentation: Added explanatory comment in writing.md clarifying the split ("General tone and formatting rules live in base.md...")
  • Consistent structure: Both files maintain clear section headers and formatting

Potential Issues 🔍

None identified. The refactoring is straightforward with no logic changes or dependencies that could break.

Performance Considerations ⚡

Not applicable for configuration files.

Security Concerns 🔒

No security implications for this rules refactoring.

Test Coverage ✅

As noted in the PR description, no code changes were made - this is purely a rules reorganization. The test plan appropriately indicates no testing needed.

Minor Observations

  • The new "load-bearing" restriction is a nice addition for maintaining clear, unpretentious language
  • The file organization now better reflects the scope of each rule set

Conclusion

Approved - This is a well-executed refactoring that improves the organization and clarity of the Claude configuration rules. The changes achieve the stated goal of making tone and formatting rules apply universally while preserving prose-specific guidelines where appropriate.

@johnae johnae merged commit 6108a9e into main May 4, 2026
2 of 4 checks passed
@johnae johnae deleted the push-omlqyrxolzmq branch May 4, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant