Skip to content

fix(knowledge): centralize KnowledgeEntry serialization - #180

Closed
DhruvGarg111 wants to merge 1 commit into
johnnichev:mainfrom
DhruvGarg111:fix/145-knowledge-entry-serialization
Closed

DhruvGarg111 wants to merge 1 commit into
johnnichev:mainfrom
DhruvGarg111:fix/145-knowledge-entry-serialization

Conversation

@DhruvGarg111

Copy link
Copy Markdown
Contributor

Summary

  • centralize the nine-field KnowledgeEntry mapping in shared JSON-shaped serialization helpers
  • use the shared mapping across file, SQLite, Redis, and Supabase stores while preserving each backend's wire format
  • coerce importance consistently to float, including legacy SQLite rows, and normalize nullable defaults
  • add regression and round-trip coverage for every affected backend

Testing

  • python -m ruff format --check on all modified Python files
  • python -m ruff check on all modified Python files
  • focused knowledge-store suite: 116 passed
  • architecture suite: 1,194 passed

Closes #145

@johnnichev
johnnichev self-requested a review August 6, 2026 14:53
@DhruvGarg111 DhruvGarg111 closed this by deleting the head repository Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KnowledgeEntry serialization duplicated 4x, plus an importance float() coercion bug

1 participant