fix(build): migrate build-mcpb to archiver v8 named exports#15
Merged
Conversation
archiver 8.0.0 (bumped in #11) is pure ESM and replaced the default archiver("zip", opts) factory with named class exports; the v0.2.2 publish workflow failed at "Build MCPB bundle" with "does not provide an export named 'default'". Use `new ZipArchive(opts)` instead. Also run build:mcpb in CI so packaging breakage from dependency bumps surfaces on PRs instead of at release-tag time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archiver("zip", opts)factory in favor of named class exports. Nothing was published (the failure happened beforenpm publishand release creation).import { ZipArchive } from "archiver"+new ZipArchive({ zlib: { level: 9 } }). The rest of the API (pipe/file/directory/finalize) is unchanged.npm run build:mcpbon PRs, so a dependency bump can't silently break packaging until a release tag again (this is exactly how build(deps-dev): bump archiver from 7.0.1 to 8.0.0 #11 slipped through — CI never exercised the build script).Test plan
npm ci(archiver 8.0.0) +npm run build:mcpblocally: buildsmassive-mcp-0.2.2.mcpb, archive contents verified withunzip -lbuild:mcpbstep on Node 20 and 22After merge: re-point the
v0.2.2tag to rerun the publish workflow.🤖 Generated with Claude Code