fix: quote copied cells so values with delimiters survive paste - #100
Open
RByers wants to merge 1 commit into
Open
fix: quote copied cells so values with delimiters survive paste#100RByers wants to merge 1 commit into
RByers wants to merge 1 commit into
Conversation
Copying a cell containing the file separator (e.g. `a,b` in a .csv) and pasting it split the value across cells, because the webview joined raw cell text with the separator and never quoted it, while paste parses with RFC 4180 quoting. The webview now sends the selected cells as a matrix and the host serializes it with Papa.unparse using the active delimiter, mirroring how paste already parses on the host. This also preserves trailing empty cells on TSV copies (previously eaten by trimEnd) and uses textContent for consistency with the edit path. Adds round-trip tests for the copy serializer and a webview contract test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011mdKM44h3kz5FrmrxZT2YN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying a cell containing the file separator (e.g.
a,bin a .csv) and pasting it split the value across cells, because the webview joined raw cell text with the separator and never quoted it, while paste parses with RFC 4180 quoting.The webview now sends the selected cells as a matrix and the host serializes it with Papa.unparse using the active delimiter, mirroring how paste already parses on the host. This also preserves trailing empty cells on TSV copies (previously eaten by trimEnd) and uses textContent for consistency with the edit path.
Adds round-trip tests for the copy serializer and a webview contract test.
Fixes #81