Validate class, namespace and attributes in PHP::objectToString() - #86
Open
Hackwar wants to merge 1 commit into
Open
Validate class, namespace and attributes in PHP::objectToString()#86Hackwar wants to merge 1 commit into
Hackwar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When calling
Registry::toString('PHP', ['class' => '<classname>', 'namespace' => '\\Name\\Space'])on a registry object, thePHPformatter is called and creates a string with a PHP class in it. For the class name and the namespace name, it uses the options here and for the attribute names it uses the keys in the registry object. All of these can be almost arbitrary strings and when writing it out as a PHP class, they are not validated. So in a hypothetical scenario, you could set theclassoption toTest {static function run() {/**arbitrary code**/}} Test::run(); class SomethingElseand that would inject code into this class. While the scenario is pretty complex, this PR still fixes it. It ensures that classes, attributes and namespaces only contain valid characters.