Restore README GIF demo#30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes README demo rendering by replacing the stripped local video embed with a clickable thumbnail linking to the MP4 demo, and aligns the VHS documentation/output with the MP4 asset.
Changes:
- Replaced the README
<video>tag with a centered thumbnail link tomedia/IHDEdit.mp4. - Updated the VHS tape output from
media/demo.giftomedia/IHDEdit.mp4. - Updated VHS documentation to reference the MP4 output and explain the README thumbnail workaround.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
README.md |
Uses media/billboard.png as a linked thumbnail for the demo MP4. |
vhs/intune-hydration-tui.tape |
Changes generated demo output to media/IHDEdit.mp4. |
vhs/README.md |
Documents the new MP4 output and GitHub README video rendering limitation. |
jorgeasaurus
force-pushed
the
fix/readme-demo-link
branch
from
9bf5316 to
c6ba5cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media/demo.gifembed that GitHub renders correctly.media/demo.gif.Validation
vhs validate vhs/intune-hydration-tui.tapegit diff --check