Skip to content

Security-related changes #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josegonzalez merged 2 commits into from
Apr 30, 2026
+2 −2
Merged

Security-related changes #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddf7f82
add missing `context` argument to `urlopen` call
Changaco Apr 10, 2026
2f130ec
remove bad invocation of the system shell
Changaco Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions github_backup/github_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,7 +1297,7 @@ def get_jwt_signed_url_via_markdown_api(url, token, repo_context):
request.add_header("Content-Type", "application/json")
request.add_header("Accept", "application/vnd.github+json")

html = urlopen(request, timeout=30).read().decode("utf-8")
html = urlopen(request, context=https_ctx, timeout=30).read().decode("utf-8")

# Parse JWT-signed URL from HTML response
# Format: <img src="https://private-user-images.githubusercontent.com/...?jwt=..." ...>
Expand Down Expand Up @@ -2980,7 +2980,7 @@ def fetch_repository(
masked_remote_url = mask_password(remote_url)

initialized = subprocess.call(
"git ls-remote " + remote_url, stdout=FNULL, stderr=FNULL, shell=True
["git", "ls-remote", remote_url], stdout=FNULL, stderr=FNULL
)
if initialized == 128:
if ".wiki.git" in remote_url:
Expand Down