ogt_vox: instance and group save order implementation#85
Open
dougbinks wants to merge 1 commit intojpaver:masterfrom
Open
ogt_vox: instance and group save order implementation#85dougbinks wants to merge 1 commit intojpaver:masterfrom
dougbinks wants to merge 1 commit intojpaver:masterfrom
Conversation
dougbinks
changed the title
mgerhardy
requested changes
Apr 19, 2026
| uint32_t unassinged_groupIds = 0; | ||
| uint32_t group_index = instance->group_index; | ||
| while (group_index != k_invalid_group_index) | ||
| { |
Collaborator
There was a problem hiding this comment.
the formatting is wrong here
| uint32_t groupsToWrite = instance->_nodeId - nodeIdToWrite; | ||
| while (instance->_nodeId - nodeIdToWrite) | ||
| { | ||
| // write out any groups |
Collaborator
There was a problem hiding this comment.
formatting is also wrong here.
| _vox_file_write_chunk_nTRN(fp, node_id, child_node_id, instance->name, instance->hidden, &instance->transform, instance->layer_index, &instance->transform_anim); | ||
| uint32_t groupsToWrite = instance->_nodeId - nodeIdToWrite; | ||
| while (instance->_nodeId - nodeIdToWrite) | ||
| { |
Collaborator
There was a problem hiding this comment.
also this block uses wrong formatting
Collaborator
Author
|
Thanks for these - I'm bad at spotting formatting as I'm dyslexic. I take it the issue here is that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds group and instance ordering to ensure that a file written by
ogt_vox.hwill preserve the instance ordering required for correct rendering.The ordering is primarily based on the instance order in the scene.
This adds a
mutable uint32_t _nodeIdto theogt_vox_instanceandogt_vox_groupstructs.Some issues:
mutable uint32_t _nodeId).This PR would resolve #84 for file version 200.