Open
Conversation
jrabbit
reviewed
Oct 14, 2019
Owner
jrabbit
left a comment
jrabbit
left a comment
There was a problem hiding this comment.
had some first pass ideas. You should consider rebasing on three_only
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| class Registry(object): |
Owner
There was a problem hiding this comment.
I'm actively dropping python 2 support so this can be the py3 native declaration.
|
|
||
| def __init__(self, mod_irc): | ||
| self.registered = {} | ||
| self.mod_irc = mod_irc |
Owner
There was a problem hiding this comment.
should be generic pending #93 or mod specific to avoid confusion in traceback/debugging.
|
|
||
|
|
||
| @cli_base.command() | ||
| @click.option("--conf-file", default="telegram.toml") |
Owner
There was a problem hiding this comment.
needs to be resolved from the folder global.
Owner
There was a problem hiding this comment.
so like Path(folder, "conf", "telegram.toml")?
Owner
|
oh a changelog line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add telegram mod (#91)