Open
Conversation
blakeembrey
commented
Apr 3, 2026
| if (semiIndex === -1 || options?.parameters === false) return { type }; | ||
|
|
||
| const parameters = parseParameters(header, end, len); | ||
| const parameters = parseParameters(header, end + 1, len); |
Member
Author
There was a problem hiding this comment.
Some readability tweaks in case we want to expose parseParameters later. No change in overall performance by making this change now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 107 112 +5
Branches 40 41 +1
=========================================
+ Hits 107 112 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packages, such as
type-is, only need thetypefrom the header and don't use the parameters. Passingparameters: falsein those cases uses the faster path by exiting early which is 10X faster with just a couple of parameters.