Clarify Guardrail: Policy decides, HITL and workflows enforce - #49
Merged
Merged
Conversation
Nest Policy, HITL, and workflows under Guardrail with one GuardrailDecision vocabulary, admit workflow starts and web.crawl through that policy, and drop stale scratch docs/scripts. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace hardcoded workflow/effector allowlists with store-backed Policy evaluation; thin adapters apply allow, deny, confirmHITL, and redact at WorkflowRuntimeEngine and MCPService. Co-authored-by: Cursor <cursoragent@cursor.com>
Chokepoints now only evaluate Policy rules then apply GuardrailDecision; remove interceptor and admission-policy types that duplicated that path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structure/Guardrailumbrella with Policy, HITL, and Workflow contracts driven byGuardrailDecision.WorkflowRuntimeEngineviaWorkflowAdmissionPolicy(UI proposes; Guardrail authorizes). KeeppluginFactoryEditdenied as a placeholder.web.crawlin MCPService; consolidate store-backed and in-memory policy onto the same decision surface.todo.rtf, fix broken doc links, widen local DB reset paths.Closes #45
Test plan
swift test --filter Guardrailinpackages/Structureswift testinpackages/MemorySystemandpackages/PolicyRuntimeswift test --filter WorkflowIntegrationinpackages/DerrickBackendpluginFactoryEditis rejected until that kind is enabledMade with Cursor