Add tests for always-empty columns fix and variableMeasured completeness#49
Open
htsukamoto5 wants to merge 3 commits into
Open
Add tests for always-empty columns fix and variableMeasured completeness#49htsukamoto5 wants to merge 3 commits into
htsukamoto5 wants to merge 3 commits into
Conversation
Three cases: all columns populated (baseline), one always-empty column, and a sparse CSV with different trial types populating different columns. Each test asserts that every column header appears in variableMeasured. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add comment to csvColumnNames noting the no-quoted-commas assumption - Add baseline comment to the all-columns-populated test clarifying intent - Assert description:"unknown" on always-empty column to pin getList() serialization - Add comment explaining why JSON input is not tested (non-rectangular structure is a separate issue) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 43f7504 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variableMeasuredaftergenerate(): baseline (all columns populated), one always-empty column, and a sparse/multi-trial-type CSVTest plan
npm testinpackages/metadata— all tests should pass🤖 Generated with Claude Code