Add Jest test infrastructure and tests for CLI package#51
Open
htsukamoto5 wants to merge 4 commits into
Open
Conversation
Sets up jest with @sucrase/jest-plugin (node environment) and adds 14 tests across two suites: expandHomeDir and generatePath in utils.test.ts, validateDirectory and validateJson in validatefunctions.test.ts. Tests use real temp directories/files via os.tmpdir() rather than mocks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…essDirectory 13 tests covering the core data functions using real temp directories. processDirectory tests cover CSV/JSON files, unsupported file types, one-level subdirectory recursion, and dataset_description.json handling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaced callback-based fs.writeFile with fs.promises.writeFile so saveTextToPath returns a Promise. Updated the two saveTextToPath tests to await the call directly, removing the setTimeout/done workaround. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: da2e8d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sucrase/jest-plugintest infrastructure topackages/cliutils.ts,validatefunctions.ts, anddata.ts(27 tests total, all passing)saveTextToPathfrom callback-basedfs.writeFiletoasync/awaitwithfs.promises.writeFileNotes
index.tsandhandlefiles.tsare intentionally out of scope — testing the interactive@inquirer/promptsentrypoint would require a separate mocking effort.Test plan
cd packages/cli && npx jest— all 27 tests passpackages/metadatatests🤖 Generated with Claude Code