Fix to built on macOS, sync to pilot-link Blob_t API, fall back to glibtoolize#76
Open
desrod wants to merge 1 commit into
Open
Fix to built on macOS, sync to pilot-link Blob_t API, fall back to glibtoolize#76desrod wants to merge 1 commit into
desrod wants to merge 1 commit into
Conversation
…ibtoolize jp-pi-contact.h, jp-contact.c: Update jp_Contact_add_blob() signature from `struct ContactBlob *` to 'Blob_t *' to match pilot-link's API. The struct was renamed upstream in pilot-link commit 51d934b7 (Sep 2021), leaving the jp shim with a dangling forward declaration that conflicts with the real prototype in <pi-contact.h>. Linux builds picked up the new header too, so this fixes the build on every current platform, not just macOS. autogen.sh: This biases to libtoolize on Linux and falls back to glibtoolize when only the latter is present. Homebrew on macOS installs the GNU libtool tools with a 'g' prefix to avoid colliding with Apple's /usr/bin/libtool Linux is unaffected here because libtoolize is found first. I verified this end-to-end on my macOS 26.5 machine (aarch64-apple-darwin) against pilot-link 0.15.0 installed at /usr/local. The whole tree now builds clean against pl 0.15.0 API and ABI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to
jp-pi-contact.h,jp-contact.c:Update
jp_Contact_add_blob()signature fromstruct ContactBlob *toBlob_t *to match pilot-link's API. The struct was renamed upstream in pilot-link commit 51d934b7 (Sep 2021), leaving the jp shim with a dangling forward declaration that conflicts with the real prototype inpi-contact.h. Linux builds picked up the new header too, so this fixes the build on every current platform, not just macOS.Another small fix to
autogen.sh:This biases to
libtoolizeon Linux and falls back toglibtoolizewhen only the latter is present. Homebrew on macOS installs the GNUlibtooltools with a 'g' prefix to avoid colliding with Apple's/usr/bin/libtool. Linux is unaffected here becauselibtoolizeis found first.I verified this end-to-end on my macOS 26.5 machine (aarch64-apple-darwin) against pilot-link 0.15.0 installed at
/usr/local. The whole tree now builds clean against pl 0.15.0 API and ABI.