Add bridge attribute for choosing the Cholesky backend#2985
Closed
Add bridge attribute for choosing the Cholesky backend#2985
Conversation
Member
|
I vote no. Let's wait a while to see if we need this. There is no benefit to making the bridge more complicated just for the sake of it. |
odow
reviewed
Apr 1, 2026
| sqrt_ret = _compute_sparse_sqrt(LinearAlgebra.Symmetric(Q)) | ||
| Q_sym = LinearAlgebra.Symmetric(Q) | ||
| sqrt_ret = if bridge.method !== nothing | ||
| _compute_sparse_sqrt(bridge.method, Q_sym) |
Member
There was a problem hiding this comment.
For example, adding this attribute would also require us to make these methods public and commit to their API, etc.
Member
|
It took 4 years to close #1971 with few, if any, people complaining. I don't think it is a high priority. |
Member
|
Agreed this additional complexity seems premature. |
Member
|
Closing as won't fix. It's nice to know that there is an approach that can work with the bridges, but I don't think that now is the time to add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by blegat/ComplementOpt.jl#29