implement operate_to!!(::BigInt, ::typeof(copy), ::T) for small int T#357
implement operate_to!!(::BigInt, ::typeof(copy), ::T) for small int T#357blegat merged 2 commits intojump-dev:masterfrom
Conversation
GMP natively supports integer types no wider than `Clong` or `Culong`, so make use of that. A followup PR may add support for generic subtypes of `Integer`, too. Fixes jump-dev#354
nsajko
force-pushed
the
BigInt-set-set_ui-set_si
branch
from
460f4d6 to
b20ebda
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.02%
==========================================
Files 23 23
Lines 2307 2315 +8
==========================================
+ Hits 2113 2120 +7
- Misses 194 195 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Codecov is saying the PR indirectly diminishes coverage. However I am not able to view the indirect changes to coverage in the Codecov Web UI, getting error 400. |
Co-authored-by: Benoît Legat <benoit.legat@gmail.com>
| function operate_to!( | ||
| out::BigInt, | ||
| ::typeof(copy), | ||
| in::Union{Bool,Int8,Int16,Int32,Clong,UInt8,UInt16,UInt32,Culong,BigInt}, |
There was a problem hiding this comment.
Not a big fan of calling a variable in, it will make Julia parsers and interpeters trip because it's used in x in set
There was a problem hiding this comment.
I agree, however that is what the surrounding code does. So I followed the pattern for consistency.
There was a problem hiding this comment.
Indeed, then that's a separate issue
2 participants
GMP natively supports integer types no wider than
ClongorCulong, so make use of that.A followup PR may add support for generic subtypes of
Integer, too.Fixes #354