Skip to content

perf: fix partial success auth - #1

Merged
LeeEirc merged 1 commit into
partial_authfrom
fix_partial_auth
Aug 23, 2026
Merged

perf: fix partial success auth#1
LeeEirc merged 1 commit into
partial_authfrom
fix_partial_auth

Conversation

@LeeEirc

@LeeEirc LeeEirc commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI lite review requested due to automatic review settings August 23, 2026 02:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SSH server’s authentication callbacks to avoid returning permissions when authentication completes with partial success, and refreshes the module/toolchain and x/* dependencies used by the server.

Changes:

  • Return nil permissions when propagating PartialSuccessError from password, public-key, and keyboard-interactive auth callbacks.
  • Propagate the same nil-permissions behavior through nested/continued partial-success auth flows.
  • Bump the module’s Go version and update golang.org/x/crypto/golang.org/x/sys (and resulting go.sum).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
server.go Ensures permissions aren’t returned alongside partial-success auth errors in server auth callbacks.
go.mod Raises Go version and updates key golang.org/x/* dependencies.
go.sum Reflects dependency graph changes from the go.mod update/tidy.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread go.mod
module github.com/gliderlabs/ssh

go 1.17
go 1.25.0
@LeeEirc
LeeEirc merged commit b24074a into partial_auth Aug 23, 2026
1 check passed
@LeeEirc
LeeEirc deleted the fix_partial_auth branch August 23, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants