Skip to content

Allow nullable ID in findOne method #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justim merged 2 commits into from
May 27, 2026
Merged

Allow nullable ID in findOne method #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6446309
Allow findOne method to accept null ID
yrodchyn May 26, 2026
63085dc
Allow nullable ID parameter in findOne method
yrodchyn May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,10 @@ public function getRepository(string $klass): Repository
* @psalm-return ?TEntity
*
* @param string $klass Entity class name
* @param int $id ID of the entity
* @param ?int $id ID of the entity
* @return ?Entity
*/
public function findOne(string $klass, int $id): ?Entity
public function findOne(string $klass, ?int $id): ?Entity
{
return $this->getRepository($klass)->findOne($id);
}
Expand Down
8 changes: 6 additions & 2 deletions src/Repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,15 @@ public function __construct(Database $db, string $klass)
/**
* Find a single entity by its ID
*
* @param int $id ID of the entity
* @param ?int $id ID of the entity
* @psalm-return ?TEntity
*/
public function findOne(int $id): ?Entity
public function findOne(?int $id): ?Entity
{
if ($id === null) {
return null;
}

return $this->findOneBy([
'id' => $id,
]);
Expand Down
Loading