Skip to content

Preserve view state when switching color spaces#98

Open
justnullname wants to merge 1 commit intomainfrom
fix-preserve-zoom-on-color-space-switch-10213532648501565485
Open

Preserve view state when switching color spaces#98
justnullname wants to merge 1 commit intomainfrom
fix-preserve-zoom-on-color-space-switch-10213532648501565485

Conversation

@justnullname
Copy link
Copy Markdown
Owner

Fixes an issue where changing the Color Space or toggling RAW Mode resets the user's current zoom and pan view.


PR created automatically by Jules for task 10213532648501565485 started by @justnullname

…mode

When right-clicking to switch color spaces, toggle soft proofing, or
enable/disable RAW rendering, the image is re-decoded and re-uploaded
to the GPU, causing the `AdjustWindowToImage` system to reset the user's
current zoom scale and pan offsets to default (Fit Window).

This patch introduces a dedicated global flag (`g_preserveViewStateOnNextLoad`)
and a storage struct (`g_preservedViewState`) to seamlessly persist the
`g_viewState` across these specific user-initiated asynchronous image reloads.

Once the new image resource completes decoding and reaches `ProcessEngineEvents`,
the original zoom and pan are cleanly restored to the hardware
composition engine matrix immediately before the `SyncDCompState` update.
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant