Skip to content

added #int reader#101

Open
source-c wants to merge 14 commits into
juxt:masterfrom
source-c:master
Open

added #int reader#101
source-c wants to merge 14 commits into
juxt:masterfrom
source-c:master

Conversation

@source-c

@source-c source-c commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

for native Java services there are a lot of cases when numeric have to be strictly passed as integer. to avoid manual handling such needs #int reader to be added.

source-c and others added 12 commits October 21, 2016 14:42
- for lein and jars behaves same
- able to handle mixed includes
fix sample code in documentation
for native Java services there are a lot of cases when numeric have to be strictly passed as integer. 
to avoid manual handling such needs #int reader to be added.
@codecov-commenter

codecov-commenter commented Nov 5, 2021

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.24%. Comparing base (743e9bc) to head (e13104b).
⚠️ Report is 19 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   79.13%   79.24%   +0.11%     
==========================================
  Files           4        4              
  Lines         369      371       +2     
  Branches       17       17              
==========================================
+ Hits          292      294       +2     
  Misses         60       60              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olymk2

olymk2 commented Dec 13, 2021

Copy link
Copy Markdown

Any chance this can be merged ? just hit this myself configuring a db pool

DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP

:pool-opts {:maximumPoolSize #or [#env "DB_POOL_MAX_SIZE" 3]}

@source-c

Copy link
Copy Markdown
Contributor Author

Hello. Is there a chance the request become merged?

@source-c

source-c commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

Any chance this can be merged ? just hit this myself configuring a db pool

DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP

:pool-opts {:maximumPoolSize #or [#env "DB_POOL_MAX_SIZE" 3]}

You are welcome to use https://github.com/dkdhub/edn-config instead. It is a drop-in replacement with #int reader enabled out-of-the-box.

@joelittlejohn

Copy link
Copy Markdown
Contributor

Seems fine to add an #int reader as we have #long and #double.

I don't like, however, that this allows two different ways to specify the int value in the edn: as an int or a string. This is a surefire way to make config inconsistent, with different styles used in different places, and engineers not being sure how they're supposed to specify values. Every other value is specified as a string, so we should stick with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants