Deck detail says what the deck can be studied with - #335
Merged
Merged
Conversation
The opt-ins were settable at publish and in the editor and readable nowhere else, so the reader deciding whether to keep a deck was the one person who could not find out what it offered. Listen and Speak are folded through speechReady on the way out, as the study session and the editor already do: with no declared language pair the session offers neither button, so passing them on would let a screen advertise a feature it withholds. Type and Both directions are ungated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A STUDY MODES row between the tags and the stats bar, one chip per opt-in the author turned on. Icons and labels are the editor's own, so the row names the switches its author actually flipped. Two things the first build got wrong on a device. The chips take the primary accent rather than the editor's alternating pair: purple on a soft purple pill is what TagChip is, so four of them under the tag row read as four more tags. And the caption is there for the same reason — without it a second row of pills is just more tags. Read-only: these are the author's decisions, not the reader's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Mirrors the Android row: caption, one badge per opt-in, primary accent throughout so a badge never reads as a TagChipView. It scrolls sideways like the tag row above it, which is the pattern the screen already uses for a row of pills. Unbuilt and undriven — written on a Linux box, so it needs a Mac pass before it counts as verified. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Records the 2026-09-23 device run — phone light and dark, tablet at both the medium and expanded width classes — and the gate worth re-testing: an opt-in with no language pair must not put a chip on the screen. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four study opt-ins — Listen, Speak, Type the answer, Both directions — were settable at publish
and in the deck editor and shown nowhere else. The reader deciding whether to keep a deck was the
one person who could not find out what it offered.
Deck detail now carries a
STUDY MODESrow between the tags and the stats bar, one chip per opt-inthe author turned on, reusing the deck editor's own icons and labels so the row names the switches
its author actually flipped. Read-only — these are the author's decisions, not the reader's.
Two things worth knowing
Listen and Speak are folded through
speechReadybefore they reach the screen, as the studysession and the editor already do. A deck with the opt-in on and no declared language pair offers
neither button, so a chip there would advertise a feature the session withholds. Type and Both
directions are ungated, as everywhere else.
All four chips take the primary accent, not the editor's alternating pair. Speak and Both
directions are purple in the editor — but purple on a soft purple pill is exactly what
TagChipis, and the first build put them directly under the tag row where they read as more tags. Orange
says what the deck does, purple says what it is about; the caption is the second half of that
separation.
Verified
Driven on
Medium_Phone(staging): one chip, then the language pair added in the editor and theListen chip appearing, in light and dark; and on
Pixel_Tabletat both the medium and expandedwidth classes.
ciCheck,detektAll,:shared:jvmTestandcheckStringPluralsall pass. Fullrun in
journeys/RESULTS.md, with journey 26 extended to cover the row and the gate.iOS is unbuilt — written on a Linux box, so
DeckFeatureBadges.swiftand its two wiring linesneed a Mac pass before they count as verified.
🤖 Generated with Claude Code