fix(ios): match the Ring QR sheet to Android and fill its background - #342
Merged
Merged
Conversation
The sheet painted its colour with .background on the content, so the rest of the .large detent showed system material. Use .presentationBackground and size the detent to the content. Layout now follows RingScanHandoff.kt: card surface, 220pt code, no spinner, text Copy link, Get the app only without Ring, and no Cancel since dragging the sheet already cancels. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.backgroundon its content, so the.largedetent showed system material below it. It now uses.presentationBackground(surfaceCard)..large. It clamps to full height on short phones, where the ScrollView scrolls.RingScanHandoff.kt: card surface, 20pt heavy title, secondary body, 220pt QR, waiting line without a spinner, text-style Copy link, "Get the app" only when Ring isn't installed, and no Cancel button (drag-dismiss already callsonCancelSignIn).Verified on iPhone 17e (light and dark) and iPad Pro 11-inch (M5) portrait. Not verified: the iPad inline panel in landscape.
🤖 Generated with Claude Code