Skip to content

fix(server): use POST instead of GET for check endpoint#168

Merged
mdevolde merged 1 commit into
jxmorris12:masterfrom
mdevolde:fix/check_method
May 14, 2026
Merged

fix(server): use POST instead of GET for check endpoint#168
mdevolde merged 1 commit into
jxmorris12:masterfrom
mdevolde:fix/check_method

Conversation

@mdevolde
Copy link
Copy Markdown
Collaborator

fix(server): use POST instead of GET for check endpoint

Why the pull request was made

This PR allows our lib to use the proper method to contact the endpoint, and btw, to avoid having all our params in web server logs (because with get, the params are in the url).

Summary of changes

  • Changed the http verb from get to post for check endpoint.

Screenshots (if appropriate):

Not applicable.

How has this been tested?

Applied local tests.

Resources

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation only)
  • Refactor / code style update (non-breaking change that improves code structure or readability)
  • Tests / CI improvement (adding or updating tests or CI configuration only)
  • Other (please describe):

Checklist

  • Followed the project's contributing guidelines.
  • Updated any relevant tests.
  • Updated any relevant documentation.
  • Added comments to your code where necessary.
  • Formatted your code, run the linters, checked types and tests.

@mdevolde mdevolde self-assigned this May 14, 2026
@mdevolde mdevolde merged commit 210a8a2 into jxmorris12:master May 14, 2026
8 checks passed
@mdevolde mdevolde deleted the fix/check_method branch May 14, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant