Conversation
This was
linked to
issues
Apr 20, 2026
Closed
This was
linked to
issues
Apr 20, 2026
Closed
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bundles several small functional updates across the firmware, mainly improving JSON safety in network responses, extending DHT11-derived environmental reporting, and adding an optional “reboot after save” flow for configuration.
Changes:
- Add JSON string sanitization and apply it to WiFi command responses and sensor status JSON keys.
- Extend DHT11 sensor reporting with dew point, comfort, and condensation risk (including MQTT channel expansion).
- Add optional reboot-on-save behavior and fix a timezone wrap issue in sun time calculations.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| SmartFuseBox/WifiCommandBridge.cpp | Sanitizes captured ACK key/value strings before embedding in JSON response. |
| SmartFuseBox/SystemFunctions.h | Adds declarations for JSON sanitization and reboot support helpers. |
| SmartFuseBox/SystemFunctions.cpp | Implements sanitizeJsonString(), canReboot(), and reboot(). |
| SmartFuseBox/SunCalculator.cpp | Wraps sunrise/sunset times to valid 0–24h range after TZ offset. |
| SmartFuseBox/SensorNetworkHandler.cpp | Sanitizes sensor names used as JSON object keys. |
| SmartFuseBox/PageVhfRadio.cpp | Sends wrapped callsign text instead of unwrapped buffer. |
| SmartFuseBox/Environment.h | Adds comfort description + condensation risk label helpers (PROGMEM). |
| SmartFuseBox/Dht11SensorHandler.h | Adds dew point/comfort/condensation to status JSON and MQTT channels. |
| SmartFuseBox/ConfigManager.cpp | Adjusts migration/defaults to reflect SystemConfig layout change. |
| SmartFuseBox/ConfigCommandHandler.cpp | Adds optional reboot behavior when saving config. |
| SmartFuseBox/Config.h | Removes rebootOnSave field, reclaims bytes as reserved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.