Skip to content

Minor fixes and updates#182

Merged
k3ldar merged 2 commits intomainfrom
minorUpdatesAndFixes
Apr 21, 2026
Merged

Minor fixes and updates#182
k3ldar merged 2 commits intomainfrom
minorUpdatesAndFixes

Conversation

@k3ldar
Copy link
Copy Markdown
Owner

@k3ldar k3ldar commented Apr 20, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 20, 2026 16:41
This was linked to issues Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bundles several small functional updates across the firmware, mainly improving JSON safety in network responses, extending DHT11-derived environmental reporting, and adding an optional “reboot after save” flow for configuration.

Changes:

  • Add JSON string sanitization and apply it to WiFi command responses and sensor status JSON keys.
  • Extend DHT11 sensor reporting with dew point, comfort, and condensation risk (including MQTT channel expansion).
  • Add optional reboot-on-save behavior and fix a timezone wrap issue in sun time calculations.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
SmartFuseBox/WifiCommandBridge.cpp Sanitizes captured ACK key/value strings before embedding in JSON response.
SmartFuseBox/SystemFunctions.h Adds declarations for JSON sanitization and reboot support helpers.
SmartFuseBox/SystemFunctions.cpp Implements sanitizeJsonString(), canReboot(), and reboot().
SmartFuseBox/SunCalculator.cpp Wraps sunrise/sunset times to valid 0–24h range after TZ offset.
SmartFuseBox/SensorNetworkHandler.cpp Sanitizes sensor names used as JSON object keys.
SmartFuseBox/PageVhfRadio.cpp Sends wrapped callsign text instead of unwrapped buffer.
SmartFuseBox/Environment.h Adds comfort description + condensation risk label helpers (PROGMEM).
SmartFuseBox/Dht11SensorHandler.h Adds dew point/comfort/condensation to status JSON and MQTT channels.
SmartFuseBox/ConfigManager.cpp Adjusts migration/defaults to reflect SystemConfig layout change.
SmartFuseBox/ConfigCommandHandler.cpp Adds optional reboot behavior when saving config.
SmartFuseBox/Config.h Removes rebootOnSave field, reclaims bytes as reserved.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread SmartFuseBox/Dht11SensorHandler.h Outdated
Comment thread SmartFuseBox/SystemFunctions.cpp Outdated
Comment thread SmartFuseBox/SystemFunctions.cpp
Comment thread SmartFuseBox/ConfigCommandHandler.cpp
Comment thread SmartFuseBox/ConfigCommandHandler.cpp
Comment thread SmartFuseBox/ConfigManager.cpp Outdated
@k3ldar k3ldar merged commit a80b665 into main Apr 21, 2026
1 check passed
@k3ldar k3ldar deleted the minorUpdatesAndFixes branch April 21, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants