Repository navigation
fix: keep thread-local touches in accessors, and trim the cost the count work added - #1231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a full before/after run of the reference-counting work against 37399c3.
release_thread_tlsfrom fix: release a task's threadlocal values when it finishes #1228 was inlined into the os-thread spawn closure, a frame that runs pith code, so it held the address ofTLS_GLOBALSandcheck-tls-barriersfailed. The touch moves behind an accessor of its own, as do the tracer buffer and the check mode's thread mark from perf: plain counts on structs only one task can reach #1230, and the barrier allowlist names them.Gates,
make rc-check-onlyand the collector tests all pass.