Repository navigation
perf: keep hot scheduler state on separate cache lines - #1232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lock_sweep/spawnbecame bimodal at #1226: some runs took about 160 ms and others about 280 ms. The instruction count rose by only 0.3%. With one worker the time was unchanged. At 16 workers, user CPU went from 2.0 s to 3.4 s. That pattern is cache-line contention, not extra work.#1226 added statics, which moved the shared stack-pool mutex onto the same cache line as
SCHEDULER. Every scheduler call readsSCHEDULER, so each lock of the pool evicted that line from every core. Inside the scheduler,searching(a compare-and-swap on every spawn) and the injector queue sat next to theworkersandslabpointers. AdjacentWorkerentries also shared lines, so a thief locking one worker's queue evicted its neighbour's.This change puts the stack pool, the scheduler,
searching, the injector and each worker on their own 64-byte lines.Interleaved medians at 16 workers on cores 0-7,16-23, main against this branch:
The other concurrency rows are unchanged.
chan_fanoutlands anywhere from about 70 to 130 ms in both builds.