feat(api): use nested structure for ModelConfig API key secret#1159
Open
syedazeez337 wants to merge 1 commit intokagent-dev:mainfrom
Open
feat(api): use nested structure for ModelConfig API key secret#1159syedazeez337 wants to merge 1 commit intokagent-dev:mainfrom
syedazeez337 wants to merge 1 commit intokagent-dev:mainfrom
Conversation
Add nested APIKeyConfig structure for ModelConfig CRD to provide consistent pattern with TLS configuration. This deprecates the flat apiKeySecret/apiKeySecretKey fields in favor of apiKey.secretRef and apiKey.secretKey. Changes: - Add APIKeyConfig struct with SecretRef and SecretKey fields - Add APIKey field to ModelConfigSpec - Mark apiKeySecret and apiKeySecretKey as deprecated - Add validation rules to prevent mixed usage - Add helper methods GetAPIKeySecretRef() and IsUsingDeprecatedAPIKeyFields() - Update reconciler to log deprecation warning - Update translator and controller to use helper method - Update HTTP handlers for backwards compatibility - Add unit and golden tests for nested API key support Closes kagent-dev#1130 Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
syedazeez337
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
EItanya
reviewed
Dec 8, 2025
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
Hey there, thanks for the PR. I think this change makes sense, but I'm a little worried that the marginal benefit of the nesting isn't necessarily worth supporting 2 APIs for the near-term. What's the motivation for this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nested APIKeyConfig structure for ModelConfig CRD to provide consistent pattern with TLS configuration. This deprecates the flat apiKeySecret/apiKeySecretKey fields in favor of apiKey.secretRef and apiKey.secretKey.
Changes:
Closes #1130