Skip to content

Fix kagent-tools fullnameOverride #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricky9408 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix kagent-tools fullnameOverride #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46391f5
Fix kagent-tools fullnameOverride
Jan 9, 2026
21c7f60
Fix clusterRoleBinding name to avoid conflict with kagent-tools chart
ricky9408 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/kagent/templates/rbac/clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "kagent.fullname" . }}-getter-rolebinding
name: {{ include "kagent.fullname" . }}-controller-getter-rolebinding
labels:
{{- include "kagent.labels" . | nindent 4 }}
roleRef:
Expand All @@ -16,7 +16,7 @@ subjects:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "kagent.fullname" . }}-writer-rolebinding
name: {{ include "kagent.fullname" . }}-controller-writer-rolebinding
labels:
{{- include "kagent.labels" . | nindent 4 }}
roleRef:
Expand Down
2 changes: 1 addition & 1 deletion helm/kagent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ kmcp:
# ==============================================================================

kagent-tools:
fullnameOverride: kagent-tools
Copy link
Contributor

@onematchfox onematchfox Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fullnameOverride: kagent-tools
nameOverride: tools

Removing fullnameOverride will resulting in any resources created by the kagent-tools chart being created using just the release name supplied when installing this chart. See https://github.com/kagent-dev/tools/blob/9cc60665518f6c0d0bf11f10fbc07f220efa019f/helm/kagent-tools/templates/_helpers.tpl#L8-L21

I.e. in the default scenario this will result in thge deployment kagent-tools being deleted and a new deployment called kagent being created. To preserve the existing name whilst also honouring the release name supplied when installing this chart we should make use of nameOverride instead. This is how this is done for the kmcp chart as well.

FYI: This is also why you ended up having to change the name of the cluster role bindings. So, you should be able to revert that change after making this one.

fullnameOverride: "" # Override if desired
enabled: true
replicaCount: 1
resources:
Expand Down
Loading