Cleanup post transfer by EItanya · Pull Request #3 · kagent-dev/khook

EItanya · 2025-09-09T15:35:25Z

move agentId to agentRef
change khook-controller -> khook
fix build file

… build file Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

antweiss

Thank you for this massive improvement! Found a few small issues. LMK what you think.

antweiss · 2025-09-10T07:33:14Z

api/v1alpha2/hook_types.go

@@ -31,15 +31,27 @@ type EventConfiguration struct {

 	// AgentId specifies the Kagent agent to call when this event occurs


Probably need to update the variable type in the comment to AgentRef too.

antweiss · 2025-09-10T07:36:35Z

docs/installation.md


 ```bash
 TMP_DIR="$(mktemp -d)" && \
  git clone --depth 1 https://github.com/antweiss/khook.git "$TMP_DIR/khook" && \


Need to update the repo URL to https://github.com/kagent-dev/khook

antweiss · 2025-09-10T07:37:07Z

README.md

@@ -84,10 +84,10 @@ For how agents respond with either a Message or a Task in A2A, see “Life of a
   ```bash
   TMP_DIR="$(mktemp -d)" && \
     git clone --depth 1 https://github.com/antweiss/khook.git "$TMP_DIR/khook" && \


Please update the repo URL to https://github.com/kagent-dev/khook

antweiss · 2025-09-10T07:41:03Z

examples/ci-cd-monitoring.yaml

 kind: Hook
 metadata:
  name: ci-cd-monitoring
-  namespace: ci-cd


This being an example and hooks being namespaced resources I think it actually makes more sense to stay with ns 'ci-cd' - to show how hooks can be created in any namespace.

antweiss · 2025-09-10T07:42:17Z

examples/development-monitoring.yaml

 kind: Hook
 metadata:
  name: dev-monitoring
-  namespace: development


Namespace again. I think examples better show hooks in various namespaces.

antweiss · 2025-09-10T07:42:38Z

examples/multi-namespace-monitoring.yaml

 kind: Hook
 metadata:
  name: staging-monitoring
-  namespace: staging


antweiss · 2025-09-10T07:48:22Z

examples/ci-cd-monitoring.yaml

  eventConfigurations:
  # Monitor pod pending issues in CI/CD environments
  - eventType: pod-pending
-    agentId: kagent/ci-cd-engineer


And maybe add namespace to agentRef so the example explains how agents in other namespaces can be referenced. (I just realized this myself)

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

Makefile

helm/khook-crds/crds/kagent.dev_hooks.yaml

antweiss · 2025-09-14T16:47:38Z

I pushed a few fixes so that the CRD reflects the agentRef change. But now I'm getting:

Failed to call agent  for event pod-restart on resource baler: failed to create session: HTTP 400: Agent ref is invalid, please check the agent ref : failed to get model: record not found	{"type": "Warning", "object": {"kind":"Hook","namespace":"default","name":"basic-pod-monitoring","uid":"ad3d5638-8899-420c-9c85-862e6d9fd054","apiVersion":"kagent.dev/v1alpha2","resourceVersion":"16000"}, "reason": "AgentCallFailure"}

Need to debug what exactly isn't working here.

EItanya · 2025-09-14T21:57:52Z

I pushed a few fixes so that the CRD reflects the agentRef change. But now I'm getting:

Failed to call agent  for event pod-restart on resource baler: failed to create session: HTTP 400: Agent ref is invalid, please check the agent ref : failed to get model: record not found	{"type": "Warning", "object": {"kind":"Hook","namespace":"default","name":"basic-pod-monitoring","uid":"ad3d5638-8899-420c-9c85-862e6d9fd054","apiVersion":"kagent.dev/v1alpha2","resourceVersion":"16000"}, "reason": "AgentCallFailure"}

Need to debug what exactly isn't working here.

I’ll fix this tomorrow

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

antweiss · 2025-09-17T08:51:55Z

Working great now! Thanks a lot @EItanya

antweiss

LGTM. thanks @EItanya

feat: move agentId to agentRef, change khook-controller -> khook, fix…

c6a8d79

… build file Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

EItanya requested review from antweiss and yuval-k as code owners September 9, 2025 15:35

EItanya added 2 commits September 9, 2025 15:36

parallelize

dc72f67

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

fix workflow

1a1b3f5

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

EItanya changed the title ~~feat: move agentId to agentRef, change khook-controller -> khook, fix…~~ Cleanup post transfer Sep 9, 2025

EItanya added 6 commits September 9, 2025 15:44

feat: rename kind cluster to kagent to make cross work easier

ede3aa1

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

move helm into helm folder

966c5cf

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

add helm-version

1b6fcf7

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

add push-helm-chart

e2afd26

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

update release file, I think it should work

438871b

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

use newer version of release job

1f2e212

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

antweiss requested changes Sep 10, 2025

View reviewed changes

EItanya added 5 commits September 10, 2025 13:25

fix: update with new namespaced ref API

192c26c

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

change links to kagent-dev repo

f6976d7

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

remove unneeded deps

f4c255a

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

fixed the integration test

1bf2e76

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

update tests for new typed interfaces

a49f684

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

antweiss reviewed Sep 14, 2025

View reviewed changes

Makefile Outdated Show resolved Hide resolved

antweiss reviewed Sep 14, 2025

View reviewed changes

helm/khook-crds/crds/kagent.dev_hooks.yaml Show resolved Hide resolved

Update CRD definitions for agentRef

b1bb919

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

EItanya force-pushed the eitanya/api-changes branch from dd93621 to b1bb919 Compare September 15, 2025 14:16

use correct ref for session

54ad20e

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

antweiss self-requested a review September 17, 2025 08:56

antweiss approved these changes Sep 17, 2025

View reviewed changes

antweiss merged commit 19089d3 into main Sep 17, 2025
3 checks passed

antweiss deleted the eitanya/api-changes branch September 17, 2025 08:57

		@@ -31,15 +31,27 @@ type EventConfiguration struct {

		// AgentId specifies the Kagent agent to call when this event occurs

Conversation

EItanya commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antweiss left a comment

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

antweiss Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

antweiss commented Sep 14, 2025

Uh oh!

EItanya commented Sep 14, 2025

Uh oh!

antweiss commented Sep 17, 2025

Uh oh!

antweiss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EItanya commented Sep 9, 2025 •

edited

Loading