Skip to content

feat(privacy): implement privacy policy page - #16

Merged
kamycoding merged 1 commit into
mainfrom
feat/privacy-policy
Aug 9, 2026
Merged

feat(privacy): implement privacy policy page#16
kamycoding merged 1 commit into
mainfrom
feat/privacy-policy

Conversation

@kamycoding

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings August 9, 2026 12:03
@kamycoding
kamycoding merged commit c19495b into main Aug 9, 2026
1 check passed
@kamycoding
kamycoding deleted the feat/privacy-policy branch August 9, 2026 12:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 526836d8a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1 +1,224 @@
<p>privacy-policy works!</p>
<main class="privacy-policy">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset the scroll position when entering the policy

When users follow the existing privacy-policy link from the contact form near the bottom of the home page, this long article retains the document's current scroll offset and can open partway through the policy instead of at its heading. The inspected app.config.ts enables anchorScrolling but leaves scrollPositionRestoration disabled, and this component does not reset scrolling itself; enable top restoration or explicitly scroll to the top on route entry.

Useful? React with 👍 / 👎.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements a full Privacy Policy page in the Angular app and wires it into the existing legal/navigation surface so users can discover it from the site footer and see a consistent document title.

Changes:

  • Build out the Privacy Policy page (template + styling) and enable shared layout pieces (footer, router link).
  • Add unit tests for the Privacy Policy page content and footer integration.
  • Extend the site footer with a dedicated “Privacy Policy” link and align the route title formatting with the Legal Notice page.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/app/pages/privacy-policy/privacy-policy.ts Enables standalone component imports (RouterLink, Footer) and sets OnPush change detection for the page.
src/app/pages/privacy-policy/privacy-policy.html Replaces placeholder with full Privacy Policy content, back navigation link, and shared footer.
src/app/pages/privacy-policy/privacy-policy.css Adds page-specific styling consistent with the existing Legal Notice layout patterns.
src/app/pages/privacy-policy/privacy-policy.spec.ts Adds coverage to ensure key document content renders and footer/back-link integration works.
src/app/layout/footer/footer.html Adds a dedicated legal-links nav and a new “Privacy Policy” route link.
src/app/layout/footer/footer.css Updates styling to support the new legal-links nav and renamed classes.
src/app/app.routes.ts Updates the Privacy Policy route title to match the existing “...

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants