refactor(legal): extract shared legal page layout - #17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the legal pages to reuse a new shared LegalPageLayout standalone component, reducing duplicated markup/styles between Privacy Policy and Legal Notice pages while keeping page-specific content projected into the shared layout.
Changes:
- Added a new shared
LegalPageLayoutcomponent (template/styles) plus unit tests. - Updated Privacy Policy and Legal Notice pages to use
<app-legal-page-layout>with projected content. - Simplified page-specific CSS and adjusted existing specs to target the shared layout’s selectors.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/app/shared/legal-page-layout/legal-page-layout.ts | New shared standalone component providing a consistent legal page shell with required title input. |
| src/app/shared/legal-page-layout/legal-page-layout.html | Shared layout template (hero/title, back link, projected content, light footer). |
| src/app/shared/legal-page-layout/legal-page-layout.css | Shared layout styling for legal pages (hero, back link, content container, footer spacing). |
| src/app/shared/legal-page-layout/legal-page-layout.spec.ts | New unit tests verifying title signal input rendering and content projection. |
| src/app/pages/privacy-policy/privacy-policy.ts | Switched Privacy Policy page to import and use LegalPageLayout. |
| src/app/pages/privacy-policy/privacy-policy.html | Wrapped Privacy Policy content with <app-legal-page-layout> and projected existing sections. |
| src/app/pages/privacy-policy/privacy-policy.css | Removed duplicated layout CSS; kept content typography/link styling for projected content. |
| src/app/pages/privacy-policy/privacy-policy.spec.ts | Updated selector expectations to match shared .legal-page__back. |
| src/app/pages/legal-notice/legal-notice.ts | Switched Legal Notice page to import and use LegalPageLayout. |
| src/app/pages/legal-notice/legal-notice.html | Wrapped Legal Notice content with <app-legal-page-layout> and projected sections/updated timestamp. |
| src/app/pages/legal-notice/legal-notice.css | Removed duplicated layout CSS; set layout CSS variables and kept page-specific content styling. |
| src/app/pages/legal-notice/legal-notice.spec.ts | Updated selector expectations to match shared .legal-page__back. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| background-repeat: no-repeat; | ||
| background-position: center bottom; | ||
| background-size: 100% 100%; | ||
| color: var(--color-foreground); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.