feat(not-found): implement production 404 page - #22
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR implements a production-ready Not Found (404) page in the Angular app and updates routing-related tests to assert the new user-facing copy.
Changes:
- Replaces the placeholder not-found template with a styled, accessible 404 page including navigation actions and the shared footer.
- Wires up required standalone imports for routing links and footer rendering on the not-found page.
- Updates/adds tests to validate the new 404 content and to keep the project-detail redirect assertion aligned with the new page.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/pages/project-detail/project-detail.spec.ts | Updates redirect test to assert the new not-found page content. |
| src/app/pages/not-found/not-found.ts | Adds RouterLink and Footer imports for the not-found page component. |
| src/app/pages/not-found/not-found.spec.ts | Adds unit tests validating the 404 page’s key content and primary navigation link. |
| src/app/pages/not-found/not-found.html | Implements the production 404 page markup with accessible structure and router links. |
| src/app/pages/not-found/not-found.css | Adds styling for the production 404 page layout and actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.