feat: polish responsive UI and add bilingual legal pages - #26
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR polishes the responsive UI and introduces fully bilingual (EN/DE) Legal Notice and Privacy Policy pages by moving their content into the shared public/i18n/*.json translations and wiring templates/tests to ngx-translate.
Changes:
- Localize Legal Notice + Privacy Policy page titles and bodies via translation keys, with substantial new EN/DE legal content in
public/i18n/*.json. - Update/expand unit tests to validate localized titles, full legal page rendering, and language switching behavior.
- UI/UX tweaks for skills icons, contact form accessibility/layout, header logo scroll behavior, and router scroll restoration.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/testing/i18n-testing.ts | Switch test translations from inline objects to importing public/i18n/*.json. |
| src/app/pages/privacy-policy/privacy-policy.ts | Add TranslatePipe to support translated template content. |
| src/app/pages/privacy-policy/privacy-policy.html | Convert Privacy Policy content to translation-key-driven template (arrays + conditional text). |
| src/app/pages/privacy-policy/privacy-policy.spec.ts | Strengthen assertions for full EN/DE privacy policy rendering and live language switching. |
| src/app/pages/legal-notice/legal-notice.ts | Add TranslatePipe to support translated template content. |
| src/app/pages/legal-notice/legal-notice.html | Convert Legal Notice content to translation-key-driven template. |
| src/app/pages/legal-notice/legal-notice.spec.ts | Expand tests to validate complete EN/DE legal notice rendering and switching. |
| src/app/pages/home/sections/skills/skills.css | Adjust grayscale behavior to apply only on hover-capable devices. |
| src/app/pages/home/sections/contact/contact.html | Improve a11y by only setting aria-describedby and rendering error nodes when errors are visible. |
| src/app/pages/home/sections/contact/contact.css | Update contact field layout and error positioning; tweak invalid/hover states. |
| src/app/pages/home/sections/contact/contact.spec.ts | Add test asserting the privacy link route remains stable while label localizes. |
| src/app/layout/header/header.ts | Add onLogoClick() to close menu and scroll-to-top with reduced-motion support. |
| src/app/layout/header/header.html | Wire logo clicks to onLogoClick() across header variants. |
| src/app/core/i18n/localized-title.strategy.spec.ts | Extend title localization tests to cover legal routes and live language changes. |
| src/app/app.routes.spec.ts | Add a guard test ensuring legal routes and wildcard route remain unchanged. |
| src/app/app.config.ts | Enable router scrollPositionRestoration: 'top' alongside anchor scrolling. |
| public/i18n/en.json | Add EN translations for legal pages and titles. |
| public/i18n/de.json | Add DE translations for legal pages and titles. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+5
to
+6
| import DE_TRANSLATIONS from '../../../public/i18n/de.json'; | ||
| import EN_TRANSLATIONS from '../../../public/i18n/en.json'; |
| } | ||
|
|
||
| protected onLogoClick(): void { | ||
| this.closeMobileMenu(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.