fix: improve hero responsive layout - #29
Merged
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the Home page hero section to improve responsive behavior by switching the layout to a grid-based composition, using clamp()/viewport units for sizing, and simplifying/removing desktop container-query-specific styles.
Changes:
- Reworked
hero.htmlstructure to match a new grid layout (intro/CTA/polaroid as direct grid items). - Refactored
hero.cssto use CSS Grid +clamp()for responsive spacing/sizing, including updated desktop positioning rules. - Removed desktop container-query width rules for the greeting from global
styles.css.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/styles.css | Removes desktop container-query-based greeting width rules. |
| src/app/pages/home/sections/hero/hero.html | Reorders/simplifies hero markup to align with grid layout. |
| src/app/pages/home/sections/hero/hero.css | Rebuilds hero layout and responsive sizing using grid, clamp(), and updated desktop rules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| position: relative; | ||
| width: 100%; | ||
| height: 176px; | ||
| aspect-ratio: 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.