fix: align hero social icons - #30
Merged
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Aligns the Hero section’s desktop social icon column by switching to fixed desktop sizing/spacing and introducing a desktop content-width variable for positioning.
Changes:
- Introduces
--hero-desktop-content-widthfor desktop layout calculations. - Adjusts
.hero__socialsdesktop positioning using the new content width variable. - Replaces responsive
clamp(...)sizing (gap/icon size) with fixed pixel values on desktop.
Suppressed comments (1)
src/app/pages/home/sections/hero/hero.css:249
- The
leftcalculation hard-codes72px, but the stage padding-inline is responsive (clamp(32px, 5vw, 72px)). On narrower desktop widths (e.g. ~1024px), the padding will resolve below 72px, so the socials will no longer align with the stage content. Use the same padding variable in the positioning calculation to keep the socials aligned across the full desktop range.
left: max(72px, calc((100% - var(--hero-desktop-content-width)) / 2 + 72px));
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
183
to
186
| .hero__stage { | ||
| --hero-desktop-content-width: 1440px; | ||
| padding: 80px clamp(32px, 5vw, 72px) 48px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.