fix: prevent contact validation layout shift - #32
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adjusts the contact form field layout to reserve space for validation errors up-front, reducing layout shift when errors appear/disappear.
Changes:
- Converts
.contact-fieldspacing to explicit CSS grid rows (label / spacer / control / error). - Reserves a fixed “error line” height via
--contact-field-error-lineand tunes it for larger breakpoints. - Removes the prior
:has(:placeholder-shown)overlay technique for invalid fields.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
13
to
+15
| display: grid; | ||
| gap: 8px; | ||
| padding: 16px 24px; | ||
| grid-template-rows: auto 8px 22px var(--contact-field-error-line); | ||
| padding: 16px 24px 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.