fix: harden contact backend rate limiting - #33
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR strengthens the /api/contact rate limiting behavior to avoid client-controlled forwarded headers influencing rate-limit identity, and extends integration coverage for additional failure and endpoint-isolation scenarios.
Changes:
- Configure Express to not trust proxy headers and use a socket-based IP key generator for contact rate limiting.
- Extend contact integration tests to cover an additional email delivery failure category (
network). - Add integration tests ensuring rate limiting ignores
x-forwarded-forand that/api/healthremains unaffected by contact delivery failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
server/src/app.ts |
Hardens rate limiting identity by ignoring forwarded headers and generating keys from the peer socket address. |
server/test/contact.integration.test.ts |
Adds/extends integration tests for the hardened rate limiting behavior and endpoint isolation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.