chore: add contact network diagnostics - #34
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR adds safe, allow-listed network diagnostics for contact email delivery failures (Brevo fetch), so operational logs contain actionable debugging details without exposing secrets or user-submitted content.
Changes:
- Extend
EmailDeliveryErrorto carrynetworkDiagnosticsand sanitize network error details via an allow-list. - Include sanitized network diagnostics in the contact route’s logged diagnostics payload.
- Update and add integration tests to validate diagnostics shape and ensure no secret/PII leakage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
server/test/contact.integration.test.ts |
Expands diagnostics assertions and adds a new test ensuring only allow-listed network diagnostics are preserved and secrets/PII are excluded. |
server/src/services/email.service.ts |
Introduces EmailNetworkDiagnostics and sanitization helpers; attaches sanitized diagnostics to EmailDeliveryError for network failures. |
server/src/routes/contact.route.ts |
Logs the new sanitized network diagnostics alongside existing delivery failure diagnostics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.