Fix/final submission content - #38
Merged
Merged
Conversation
✅ Deploy Preview for fanciful-cannoli-268c0c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR refreshes portfolio content and improves front-end performance/UX by optimizing hero assets, adding image dimensions/lazy-loading hints, and aligning Angular routing/tests with the shared app configuration.
Changes:
- Optimized hero imagery (new background asset, responsive portrait via
<picture>, and updated preloads). - Improved image rendering stability/performance by adding
width/height,loading, anddecodingto various images. - Updated Angular routing/title handling expectations and refreshed portfolio/testimonial/project content.
Reviewed changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/styles.css | Removes global hero hover image opacity rules that are now handled in component CSS. |
| src/index.html | Updates hero background preload and adds preloads for portrait variants. |
| src/app/pages/project-detail/project-detail.spec.ts | Uses shared routes, configures LocalizedTitleStrategy, expands title assertions, and updates live URL expectation. |
| src/app/pages/project-detail/project-detail.css | Switches from physical left to logical inset-inline-end for overlay positioning. |
| src/app/pages/home/sections/testimonials/testimonials.html | Adds a CSS class to the decorative arrow image. |
| src/app/pages/home/sections/projects/projects.html | Adds intrinsic sizes and lazy/async decoding hints to project images/badges. |
| src/app/pages/home/sections/hero/hero.html | Updates hero background asset and replaces portrait markup with responsive <picture> + hover span. |
| src/app/pages/home/sections/hero/hero.css | Moves hover behavior into a desktop media query and uses a background image for the hover portrait. |
| src/app/pages/home/sections/contact/contact.ts | Adds a ViewChild for the message textarea and resets its height on successful submission. |
| src/app/pages/home/sections/contact/contact.spec.ts | Extends test to assert textarea value/height reset after successful submit. |
| src/app/pages/home/sections/contact/contact.html | Adds template ref for textarea and adds dimensions to footer arrow images. |
| src/app/layout/header/header.html | Adds intrinsic logo dimensions to reduce layout shift. |
| src/app/layout/footer/footer.html | Adds intrinsic logo dimensions to reduce layout shift. |
| src/app/features/testimonials/testimonials.model.ts | Updates testimonial ID union to reflect new testimonial entry. |
| src/app/features/testimonials/testimonials.data.ts | Replaces one testimonial’s identity/name and updates LinkedIn URL. |
| src/app/features/projects/projects.data.ts | Updates El Pollo Loco live URL. |
| src/app/app.routes.ts | Removes titleKey from the project detail route data. |
| public/i18n/en.json | Removes pageTitles.projectDetail and updates project implementation copy + testimonial text/role. |
| public/i18n/de.json | Removes pageTitles.projectDetail and updates project implementation copy + testimonial text/role. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -180,6 +172,18 @@ | |||
| } | |||
|
|
|||
| @media (min-width: 64rem) { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.