Skip to content

Follow symlinks in directory walker #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthewMckee4 merged 2 commits into from
Dec 3, 2025
Merged

Follow symlinks in directory walker #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3845a8
Follow symlinks in walker
MatthewMckee4 Dec 3, 2025
f803015
Update pydantic dependencies
MatthewMckee4 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/karva_core/src/collection/collector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ impl<'ctx, 'proj, 'rep> ParallelCollector<'ctx, 'proj, 'rep> {
.require_git(false)
.git_global(false)
.parents(true)
.follow_links(true)
.git_ignore(!self.context.project().options().no_ignore())
.types({
let mut types = ignore::types::TypesBuilder::new();
Expand Down
5 changes: 3 additions & 2 deletions crates/karva_core/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,9 @@ pub(crate) fn full_test_name(
const TRUNCATE_LENGTH: usize = 30;

pub(crate) fn truncate_string(value: &str) -> String {
if value.len() > TRUNCATE_LENGTH {
format!("{}...", &value[..TRUNCATE_LENGTH - 3])
if value.chars().count() > TRUNCATE_LENGTH {
let truncated: String = value.chars().take(TRUNCATE_LENGTH - 3).collect();
format!("{truncated}...")
} else {
value.to_string()
}
Expand Down
7 changes: 5 additions & 2 deletions crates/karva_test/src/real_world_projects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,9 @@ pub static PYDANTIC_SETTINGS_PROJECT: RealWorldProject<'static> = RealWorldProje

pub static PYDANTIC_PROJECT: RealWorldProject<'static> = RealWorldProject {
name: "pydantic",
repository: "https://github.com/pydantic/pydantic",
commit: "ed67e3ebf7c9a55de75de0e8995dbce36551eaca",
// Skip recursive test that fails crashes karva and pytest.
repository: "https://github.com/MatthewMckee4/pydantic",
commit: "17fc29cd471dd728866a729f08e0b6557cb9340b",
paths: &["tests"],
dependencies: &[
"pytest",
Expand All @@ -421,6 +422,8 @@ pub static PYDANTIC_PROJECT: RealWorldProject<'static> = RealWorldProject {
"dirty-equals",
"jsonschema",
"pytz",
"hypothesis",
"inline_snapshot",
],
max_dep_date: "2025-12-01",
python_version: PythonVersion::PY313,
Expand Down
Loading