Compatibility with the DisplayLastPost extension by Aurelienazerty#14
Open
Aurelienazerty wants to merge 3 commits intokasimi:masterfrom
Open
Compatibility with the DisplayLastPost extension by Aurelienazerty#14Aurelienazerty wants to merge 3 commits intokasimi:masterfrom
Aurelienazerty wants to merge 3 commits intokasimi:masterfrom
Conversation
Quick modification for made works with DisplayLastPost extension https://www.phpbb.com/customise/db/extension/displaylastpost/
kasimi
requested changes
Nov 12, 2017
Owner
kasimi
left a comment
kasimi
left a comment
There was a problem hiding this comment.
Just some minor code style issues, and please add a check for your config value display_last_post_show, otherwise the numbers are off if your extension's setting is set to no.
| * @param template $template | ||
| * @param db_interface $db | ||
| * @param FirstPostOnEveryPage $firstPostOnEveryPage | ||
| * @param DisplayLastPost $displayLastPost |
Owner
There was a problem hiding this comment.
Please use tabs here to fix alignment.
| $this->template = $template; | ||
| $this->db = $db; | ||
| $this->firstPostOnEveryPage = $firstPostOnEveryPage; | ||
| $this->displayLastPost = $displayLastPost; |
Owner
There was a problem hiding this comment.
Please add a tab here to fix alignment.
| return $this->first_post_num + ($is_ascending ? +$this->offset++ : -$this->offset++); | ||
| $return = $this->first_post_num + ($is_ascending ? +$this->offset++ : -$this->offset++); | ||
|
|
||
| if ($this->displayLastPost !== null && $start) { |
kasimi
reviewed
Nov 12, 2017
|
|
||
| return $this->first_post_num + ($is_ascending ? +$this->offset++ : -$this->offset++); | ||
| $return = $this->first_post_num + ($is_ascending ? +$this->offset++ : -$this->offset++); | ||
|
|
Owner
There was a problem hiding this comment.
Please remove the tabs on this empty line, same on line 334.
Author
|
New comit |
Owner
|
Could you also fix the formatting issues that I commented? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick modification for made works with DisplayLastPost extension
https://www.phpbb.com/customise/db/extension/displaylastpost/