-
Notifications
You must be signed in to change notification settings - Fork 19
Expose OpZkPrecompile builtin to SilverScript front-end #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trillskillz
wants to merge
2
commits into
kaspanet:master
Choose a base branch
from
trillskillz:feat/opzkprecompile-builtin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -458,6 +458,7 @@ fn infer_expr_type_ref_for_comparison<'i>( | |
| | "OpNum2Bin" | ||
| | "OpBin2Num" | ||
| | "OpChainblockSeqCommit" | ||
| | "OpGroth16Verify" | ||
| | "LockingBytecodeNullData" | ||
| | "ScriptPubKeyP2PK" | ||
| | "ScriptPubKeyP2SH" | ||
|
|
@@ -3582,6 +3583,8 @@ fn compile_call_expr<'i>( | |
| "OpNum2Bin" => compile_opcode_builtin_call(&mut ctx, name, args, 2, OpNum2Bin), | ||
| "OpBin2Num" => compile_opcode_builtin_call(&mut ctx, name, args, 1, OpBin2Num), | ||
| "OpChainblockSeqCommit" => compile_opcode_builtin_call(&mut ctx, name, args, 1, OpChainblockSeqCommit), | ||
| "OpGroth16Verify" => compile_groth16_verify_call(&mut ctx, args), | ||
| "OpZkPrecompile" => compile_opcode_builtin_call(&mut ctx, name, args, 0, OpZkPrecompile), | ||
| "bytes" => compile_bytes_call(&mut ctx, args), | ||
| "length" => compile_length_call(&mut ctx, args), | ||
| "int" | "byte" | "bool" | "string" | "sig" | "pubkey" | "datasig" => compile_passthrough_cast_call(&mut ctx, name, args), | ||
|
|
@@ -3791,6 +3794,33 @@ fn compile_blake2b_call<'i>(ctx: &mut CompileCallContext<'_, 'i>, args: &[Expr<' | |
| Ok(()) | ||
| } | ||
|
|
||
| fn compile_groth16_verify_call<'i>(ctx: &mut CompileCallContext<'_, 'i>, args: &[Expr<'i>]) -> Result<(), CompilerError> { | ||
| if args.len() != 3 { | ||
| return Err(CompilerError::Unsupported("OpGroth16Verify() expects 3 arguments: verifying_key, proof, public_inputs".to_string())); | ||
| } | ||
| let ExprKind::Array(public_inputs) = &args[2].kind else { | ||
| return Err(CompilerError::Unsupported( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no opcode called opgroth16verify. Please ensure errors are representative of the actual opcode names |
||
| "OpGroth16Verify() expects the third argument to be an array literal like [a, b, c]".to_string(), | ||
| )); | ||
| }; | ||
| if public_inputs.is_empty() { | ||
| return Err(CompilerError::Unsupported("OpGroth16Verify() expects at least one public input".to_string())); | ||
| } | ||
|
|
||
| for public_input in public_inputs { | ||
| compile_call_arg_with_context(ctx, public_input)?; | ||
| } | ||
| ctx.builder.add_i64(public_inputs.len() as i64)?; | ||
| *ctx.stack_depth += 1; | ||
| compile_call_arg_with_context(ctx, &args[1])?; | ||
| compile_call_arg_with_context(ctx, &args[0])?; | ||
| ctx.builder.add_data_with_push_opcode(&[0x20])?; | ||
| *ctx.stack_depth += 1; | ||
| ctx.builder.add_op(OpZkPrecompile)?; | ||
| *ctx.stack_depth += 1 - (public_inputs.len() as i64 + 4); | ||
| Ok(()) | ||
| } | ||
|
|
||
| fn compile_checksig_call<'i>(ctx: &mut CompileCallContext<'_, 'i>, args: &[Expr<'i>]) -> Result<(), CompilerError> { | ||
| if args.len() != 2 { | ||
| return Err(CompilerError::Unsupported("checkSig() expects 2 arguments".to_string())); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| contract ZkGroth16Helper() { | ||
| entrypoint function verify( | ||
| byte[32] a, | ||
| byte[32] b, | ||
| byte[32] c, | ||
| byte[32] d, | ||
| byte[32] e, | ||
| byte[] proof, | ||
| byte[] vk | ||
| ) { | ||
| require(OpGroth16Verify(vk, proof, [a, b, c, d, e])); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| pragma silverscript ^0.1.0; | ||
|
|
||
| contract ZkMinimal() { | ||
| entrypoint function verify() { | ||
| require(OpZkPrecompile()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be such an opcode. It should be invoked via opzkprecompile and maybe we should pass args as a vector in order to ensure all of the tags are supported.